[
https://issues.apache.org/jira/browse/NIFI-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997092#comment-15997092
]
James Wing commented on NIFI-3795:
----------------------------------
I reviewed [~bbende]'s change
[cb576b7|https://github.com/bbende/nifi/commit/cb576b725ea95add2525d575fc8db52c22dd2d9f].
Everything looks good to me. Removing the build-info-no-git profile from
nifi-assembly lets the generateArchives and dir-only profiles work in an
intuitive manner, even for a source build. Tests and contrib-check pass, and
NiFi still works. Profiles active in the source build from a normal {{mvn
clean install}}:
{code}
Active Profiles for Project 'org.apache.nifi:nifi-assembly:pom:1.2.0':
The following profiles are active:
- gpg (source: external)
- generateArchives (source: org.apache.nifi:nifi-assembly:1.2.0)
- disable-doclint (source: org.apache.nifi:nifi:1.2.0)
{code}
{code}
Active Profiles for Project 'org.apache.nifi:nifi-nar-bundles:pom:1.2.0':
The following profiles are active:
- gpg (source: external)
- build-info-no-git (source: org.apache.nifi:nifi-nar-bundles:1.2.0)
- disable-doclint (source: org.apache.nifi:nifi:1.2.0)
{code}
I will merge in a moment, and close the PR.
> nifi-assembly fails with "no formats specified" error
> -----------------------------------------------------
>
> Key: NIFI-3795
> URL: https://issues.apache.org/jira/browse/NIFI-3795
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Bryan Bende
> Assignee: James Wing
> Priority: Blocker
> Fix For: 1.2.0
>
>
> After staging the 1.2.0 RC1 artifacts, I then downloaded the source zip from
> the Nexus staging repo, unzipped it and ran "mvn clean install -DskipTests"
> to verify that it would build. I encountered the below error:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:2.5.2:single (make shared
> resource) on project nifi-assembly: No formats specified in the execution
> parameters or the assembly descriptor. -> [Help 1]
> After some debugging it was determined that one difference between this build
> and the previous build that staged the artifacts, is that this build was not
> within a git repo where as the other one was.
> After running git init, adding all files, and making a commit, then the build
> passed. Still unclear as to why being in a git repo matters here, although
> every NAR now tries to use the git info from the buildnumber plugin to filter
> into the MANIFEST files.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
