[
https://issues.apache.org/jira/browse/NIFI-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013514#comment-16013514
]
ASF GitHub Bot commented on NIFI-3903:
--------------------------------------
GitHub user jvwing opened a pull request:
https://github.com/apache/nifi/pull/1814
NIFI-3903 Unit Tests for AWS Processors
* Added non-integration unit tests for Lambda, S3, SNS, and SQS processors
* Moved non-integration tests out of integration test files
* Moved SQS integration tests to IT* files for clarification
----
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jvwing/nifi NIFI-3903-aws-unit-tests-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1814.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1814
----
commit caee7b11c96e14287db97d9e6d0b059504c2de4e
Author: James Wing <[email protected]>
Date: 2017-05-11T21:48:57Z
NIFI-3903 Unit Tests for AWS Processors
* Added non-integration unit tests for Lambda, S3, SNS, and SQS processors
* Moved non-integration tests out of integration test files
* Moved SQS integration tests to IT* files for clarification
----
> Basic Unit Test Coverage for AWS Processors
> -------------------------------------------
>
> Key: NIFI-3903
> URL: https://issues.apache.org/jira/browse/NIFI-3903
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: James Wing
> Assignee: James Wing
> Priority: Minor
>
> Many of the AWS processors rely heavily on integration tests for coverage of
> major features. While there is no substitute for running the code against a
> live AWS environment, the live environment requirement means that integration
> tests are run infrequently. Regular unit tests should be included:
> * Provide coverage of basic features without integration tests
> * Demonstrate at least one mocking pattern for testing AWS request/response
> * Remove excuses for not providing unit tests with new features
> * Clarify integration tests vs. unit tests
> Processors that need help include:
> * InvokeLambda
> * DeleteS3Object, FetchS3Object, PutS3Object, ListS3
> * PutSNS
> * DeleteSQS, GetSQS, PutSQS
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
