[
https://issues.apache.org/jira/browse/NIFI-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021543#comment-16021543
]
ASF GitHub Bot commented on NIFI-3903:
--------------------------------------
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1814
OK... nice PR! Checked out the code, all LGTM, checked code coverage with
added unit tests, full build with contrib check is OK. Merging to master,
thanks for the amazing work @jvwing!
> Basic Unit Test Coverage for AWS Processors
> -------------------------------------------
>
> Key: NIFI-3903
> URL: https://issues.apache.org/jira/browse/NIFI-3903
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: James Wing
> Priority: Minor
>
> Many of the AWS processors rely heavily on integration tests for coverage of
> major features. While there is no substitute for running the code against a
> live AWS environment, the live environment requirement means that integration
> tests are run infrequently. Regular unit tests should be included:
> * Provide coverage of basic features without integration tests
> * Demonstrate at least one mocking pattern for testing AWS request/response
> * Remove excuses for not providing unit tests with new features
> * Clarify integration tests vs. unit tests
> Processors that need help include:
> * InvokeLambda
> * DeleteS3Object, FetchS3Object, PutS3Object, ListS3
> * PutSNS
> * DeleteSQS, GetSQS, PutSQS
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
