[
https://issues.apache.org/jira/browse/NIFI-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044101#comment-16044101
]
ASF GitHub Bot commented on NIFI-4049:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1904
NIFI-4049: Refactor AtomicDistributedMapCacheClient
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4049
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1904.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1904
----
commit f402f7a3f3403dbd856602aaf90fd8bbad396fc5
Author: Koji Kawamura <[email protected]>
Date: 2017-06-09T07:28:45Z
NIFI-4049: Refactor AtomicDistributedMapCacheClient
To be used with cache engines that does not have revision number.
commit d42aafa0e1365eb5e6b0436a0b86183a609ec5ec
Author: Koji Kawamura <[email protected]>
Date: 2017-06-09T07:45:37Z
NIFI-4049: Refactor AtomicDistributedMapCacheClient
Removed old methods completely.
----
> Refactor AtomicDistributedMapCacheClient to be used with cache engines that
> does not have revision number
> ---------------------------------------------------------------------------------------------------------
>
> Key: NIFI-4049
> URL: https://issues.apache.org/jira/browse/NIFI-4049
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> AtomicDistributedMapCacheClient interface defines fetch and replace method to
> atomically replace cache value. To do so, it currently uses a long revision
> value. This can be a limitation when other implementation is written against
> a cache engine that doesn't have revision concept.
> This JIRA proposes to refactor that interface by using generics to specify
> what type of revision is used by an implementation class.
> If the underlying cache engine doesn't have revision concept, the revision
> field can be used to store current cached value, and to check if the key is
> not updated at 'replace' method.
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-client-service-api/src/main/java/org/apache/nifi/distributed/cache/client/AtomicDistributedMapCacheClient.java
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
