[
https://issues.apache.org/jira/browse/NIFI-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046625#comment-16046625
]
ASF GitHub Bot commented on NIFI-4049:
--------------------------------------
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1904
+1 Tested this out and verified Wait/Notify still works as expected with
these changes.
I agree with the full refactoring... since we have component versioning now
someone could also continue to run the old versions (1.3.0) of these services
if they needed to.
I'll merge to master and start working on the updates to my Redis
implementation.
> Refactor AtomicDistributedMapCacheClient to be used with cache engines that
> does not have revision number
> ---------------------------------------------------------------------------------------------------------
>
> Key: NIFI-4049
> URL: https://issues.apache.org/jira/browse/NIFI-4049
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> AtomicDistributedMapCacheClient interface defines fetch and replace method to
> atomically replace cache value. To do so, it currently uses a long revision
> value. This can be a limitation when other implementation is written against
> a cache engine that doesn't have revision concept.
> This JIRA proposes to refactor that interface by using generics to specify
> what type of revision is used by an implementation class.
> If the underlying cache engine doesn't have revision concept, the revision
> field can be used to store current cached value, and to check if the key is
> not updated at 'replace' method.
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-client-service-api/src/main/java/org/apache/nifi/distributed/cache/client/AtomicDistributedMapCacheClient.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
