Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123502816
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -314,10 +314,8 @@ void
YamlConfiguration::parseProvenanceReportingYaml(YAML::Node *reportNode, cor
auto schedulingStrategyStr = node["scheduling
strategy"].as<std::string>();
checkRequiredField(&node, "scheduling period",
CONFIG_YAML_PROVENANCE_REPORT_KEY);
auto schedulingPeriodStr = node["scheduling period"].as<std::string>();
- checkRequiredField(&node, "host", CONFIG_YAML_PROVENANCE_REPORT_KEY);
- auto hostStr = node["host"].as<std::string>();
- checkRequiredField(&node, "port", CONFIG_YAML_PROVENANCE_REPORT_KEY);
- auto portStr = node["port"].as<std::string>();
+ checkRequiredField(&node, "url", CONFIG_YAML_PROVENANCE_REPORT_KEY);
--- End diff --
We should maintain prior functionality. Though we're not GA, we should
avoid jarring consumers who may be using a prior config. We should able to
support both conditionally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
