Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123500940
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -278,26 +301,28 @@ bool Site2SiteClientProtocol::handShake() {
}
switch (code) {
- case PROPERTIES_OK:
- logger_->log_info("Site2Site HandShake Completed");
- _peerState = HANDSHAKED;
- return true;
- case PORT_NOT_IN_VALID_STATE:
- case UNKNOWN_PORT:
- case PORTS_DESTINATION_FULL:
- logger_->log_error("Site2Site HandShake Failed because destination
port is either invalid or full");
- ret = -1;
- /*
- peer_->yield();
- tearDown(); */
- return false;
- default:
- logger_->log_info("HandShake Failed because of unknown respond code
%d", code);
- ret = -1;
- /*
- peer_->yield();
- tearDown(); */
- return false;
+ case PROPERTIES_OK:
+ logger_->log_info("Site2Site HandShake Completed");
+ _peerState = HANDSHAKED;
+ return true;
+ case PORT_NOT_IN_VALID_STATE:
+ case UNKNOWN_PORT:
+ case PORTS_DESTINATION_FULL:
+ logger_->log_error(
+ "Site2Site HandShake Failed because destination port is either
invalid or full");
+ ret = -1;
+ /*
--- End diff --
is the commented code needed here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
