[ 
https://issues.apache.org/jira/browse/NIFI-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064350#comment-16064350
 ] 

ASF GitHub Bot commented on NIFI-3983:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1863#discussion_r124187608
  
    --- Diff: 
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java
 ---
    @@ -86,6 +86,29 @@
                 .defaultValue(CLIENT_ACK.getValue())
                 .build();
     
    +    static final PropertyDescriptor DURABLE_SUBSCRIBER = new 
PropertyDescriptor.Builder()
    +                                                             
.name("Durable subscription")
    +                                                             
.description("If destination is Topic if present then make it the consumer 
durable.")
    --- End diff --
    
    Similar to the "Shared subscription", can we make it clearer to describe 
what durable subscription is? For example:
    
    > Specify whether to make the subscription durable, only effective If 
destination is a Topic. If enabled, the broker will hold messages for a 
consumer while it stops, so that it can consume those when it resumes.
    
    Is my understanding correct??


> Support ability to make JMS 2.0 durable subscriptions on Topic
> --------------------------------------------------------------
>
>                 Key: NIFI-3983
>                 URL: https://issues.apache.org/jira/browse/NIFI-3983
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Michael Andre Pearce
>
> Currently the jms consumer, only supports standard queue consumption and 
> topic subscription. For topics, in JMS 2.0 you can make shared durable 
> subscribers which gives a subscription semantic similar to queue per 
> subscription name, meaning message is delivered once per subscription. This 
> is very useful in setups using JMS 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to