[ 
https://issues.apache.org/jira/browse/NIFI-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064351#comment-16064351
 ] 

ASF GitHub Bot commented on NIFI-3983:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1863#discussion_r124187577
  
    --- Diff: 
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java
 ---
    @@ -86,6 +86,29 @@
                 .defaultValue(CLIENT_ACK.getValue())
                 .build();
     
    +    static final PropertyDescriptor DURABLE_SUBSCRIBER = new 
PropertyDescriptor.Builder()
    +                                                             
.name("Durable subscription")
    +                                                             
.description("If destination is Topic if present then make it the consumer 
durable.")
    +                                                             
.required(false)
    +                                                             
.expressionLanguageSupported(true)
    +                                                             
.defaultValue("true")
    +                                                             
.allowableValues("true", "false")
    +                                                             .build();
    +    static final PropertyDescriptor SHARED_SUBSCRIBER = new 
PropertyDescriptor.Builder()
    +                                                            .name("Shared 
subscription")
    +                                                            
.description("TIf destination is Topic if present then make it the consumer 
durable.")
    --- End diff --
    
    I found a typo here. Is it possible to add more details on how this 
configuration change consumer behavior? Something like:
    
    > Specify whether to share the subscription, only effective If destination 
is a Topic. If enabled, messages can be distributed among NiFi nodes in a 
cluster. If not, each NiFi node will work as an individual consumer and receive 
the same messages.
    
    Is my understanding above correct??


> Support ability to make JMS 2.0 durable subscriptions on Topic
> --------------------------------------------------------------
>
>                 Key: NIFI-3983
>                 URL: https://issues.apache.org/jira/browse/NIFI-3983
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Michael Andre Pearce
>
> Currently the jms consumer, only supports standard queue consumption and 
> topic subscription. For topics, in JMS 2.0 you can make shared durable 
> subscribers which gives a subscription semantic similar to queue per 
> subscription name, meaning message is delivered once per subscription. This 
> is very useful in setups using JMS 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to