Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1863#discussion_r124189413
  
    --- Diff: 
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java
 ---
    @@ -86,6 +86,29 @@
                 .defaultValue(CLIENT_ACK.getValue())
                 .build();
     
    +    static final PropertyDescriptor DURABLE_SUBSCRIBER = new 
PropertyDescriptor.Builder()
    +                                                             
.name("Durable subscription")
    +                                                             
.description("If destination is Topic if present then make it the consumer 
durable.")
    +                                                             
.required(false)
    +                                                             
.expressionLanguageSupported(true)
    +                                                             
.defaultValue("true")
    +                                                             
.allowableValues("true", "false")
    +                                                             .build();
    +    static final PropertyDescriptor SHARED_SUBSCRIBER = new 
PropertyDescriptor.Builder()
    +                                                            .name("Shared 
subscription")
    +                                                            
.description("TIf destination is Topic if present then make it the consumer 
durable.")
    --- End diff --
    
    I'd rather link to JMS spec, as users should understand the behaviour from 
spec IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to