Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1863#discussion_r124438011
--- Diff:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java
---
@@ -86,6 +86,31 @@
.defaultValue(CLIENT_ACK.getValue())
.build();
+ static final PropertyDescriptor DURABLE_SUBSCRIBER = new
PropertyDescriptor.Builder()
+
.name("Durable subscription")
+
.description("If destination is Topic if present then make it the consumer
durable. " +
+
"@see
https://docs.oracle.com/javaee/7/api/javax/jms/Session.html#createDurableConsumer-javax.jms.Topic-java.lang.String-";)
+
.required(false)
+
.expressionLanguageSupported(true)
+
.defaultValue("true")
+
.allowableValues("true", "false")
+ .build();
+ static final PropertyDescriptor SHARED_SUBSCRIBER = new
PropertyDescriptor.Builder()
+ .name("Shared
subscription")
+
.description("If destination is Topic if present then make it the consumer
shared. " +
+
"@see
https://docs.oracle.com/javaee/7/api/javax/jms/Session.html#createSharedConsumer-javax.jms.Topic-java.lang.String-";)
+
.required(false)
+
.expressionLanguageSupported(true)
+
.defaultValue("false")
+
.allowableValues("true", "false")
+ .build();
+ static final PropertyDescriptor SUBSCRIPTION_NAME = new
PropertyDescriptor.Builder()
+
.name("Subscription Name")
+
.description("The name of the subscription to use if destination is Topic and
is shared or durable.")
+
.required(false)
+
.expressionLanguageSupported(true)
+ .build();
--- End diff --
If a property descriptor doesn't have any validator, it just becomes
invalid. Please add NON_EMPTY_VALIDATOR.
```
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
```
I added above code temporarily to proceed testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
