Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1941#discussion_r125171988
--- Diff:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPWorker.java
---
@@ -47,7 +46,7 @@
* @param snmp instance of {@link Snmp}
* @param target instance of {@link AbstractTarget}
*/
- public SNMPWorker(Snmp snmp, AbstractTarget target) {
+ protected SNMPWorker(Snmp snmp, AbstractTarget target) {
--- End diff --
totally agree with you on this case! I was guilty here of seeing only a
limited section of code in my code review tool and made a bad assumption.
Totally agree that while protected and public here are mostly equivalent,
protected is a better choice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
