Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1941#discussion_r125168289
--- Diff:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPWorker.java
---
@@ -47,7 +46,7 @@
* @param snmp instance of {@link Snmp}
* @param target instance of {@link AbstractTarget}
*/
- public SNMPWorker(Snmp snmp, AbstractTarget target) {
+ protected SNMPWorker(Snmp snmp, AbstractTarget target) {
--- End diff --
In this specific case the `public` modifier didn't make any sense at all
and can't have been used outside of subclasses because it is in an abstract
class.
For all other cases I've already commented separately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
