[ 
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073332#comment-16073332
 ] 

Pierre Villard commented on NIFI-3931:
--------------------------------------

OK, I just setup a workflow (attached to this JIRA) to try with FTP processors 
(it shares the same logic with SFTP processors) and, as of now, it cannot work: 
we are not passing the flow file when initializing the client. And that's 
actually the reason behind NIFI-3281. I will submit a PR for that.

Otherwise (once this problem is fixed), it seems to be OK regarding concurrent 
threads. Meaning: it works. BUT I don't think we are actually using concurrent 
threads: it's using concurrent threads but each thread will wait for previous 
thread completion before fetching data. But I believe that's the case with or 
without expression language... After fetching a file we are doing:

{code}
client.changeWorkingDirectory(homeDirectory);
{code}

And I believe this command in synchronous, previous commands have to be 
completed before this can be actually executed.
I guess, we should add {{@TriggerSerially}} to reflect that. Thoughts?

Also if we are fetching data from the same server but on different ports, it 
would be an issue since we won't recreate a client (we are just checking if the 
remote server is changing) but it sounds unlikely to me, no? Although it would 
be a fairly easy change.

> putSftp process port property should support for expression language
> --------------------------------------------------------------------
>
>                 Key: NIFI-3931
>                 URL: https://issues.apache.org/jira/browse/NIFI-3931
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Cheng Chin Tat
>            Assignee: Pierre Villard
>            Priority: Minor
>              Labels: easyfix
>
> PutSftp Processor port property should support for expression language so 
> that dynamic port number can be pass to the processor during run time. 
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator 
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to 
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to