[
https://issues.apache.org/jira/browse/NIFI-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076909#comment-16076909
]
ASF GitHub Bot commented on NIFI-3931:
--------------------------------------
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1968#discussion_r125958747
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/SFTPIT.java
---
@@ -0,0 1,51 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.nifi.processors.standard;
import org.apache.nifi.processors.standard.util.SFTPTransfer;
import org.apache.nifi.util.TestRunner;
import org.apache.nifi.util.TestRunners;
import org.junit.Test;
public class SFTPIT {
--- End diff --
The tests executed during the builds are controlled by the surefire plugin
definition in the top level pom file:
````xml
<includes>
<include>**/*Test.class</include>
<include>**/Test*.class</include>
<include>**/*Spec.class</include>
</includes>
````
It should not be necessary to add ``@Ignore`` in this class. I believe the
convention is to use IT (and to not use Test) in the class name when
implementing integration tests.
> putSftp process port property should support for expression language
> --------------------------------------------------------------------
>
> Key: NIFI-3931
> URL: https://issues.apache.org/jira/browse/NIFI-3931
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.2.0
> Reporter: Cheng Chin Tat
> Assignee: Pierre Villard
> Priority: Minor
> Labels: easyfix
> Attachments: TestFTP.xml
>
>
> PutSftp Processor port property should support for expression language so
> that dynamic port number can be pass to the processor during run time.
> Rather than preset the port on design time.
> This changes involve changing the PropertyDescriptor SFTP_PORT validator
> StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR to
> StandardValidators.NON_EMPTY_VALIDATOR and other codes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
