[
https://issues.apache.org/jira/browse/NIFI-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085097#comment-16085097
]
ASF GitHub Bot commented on NIFI-2162:
--------------------------------------
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/2004
NIFI-2162 Updating OkHttp to 3.8.1 and OkHttp-Digest to 1.13 and refa…
…ctoring InvokeHttp to adjust for changes
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi NIFI-2162
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2004.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2004
----
commit b67ca1532765e8296442e78e7d6a781bed1167d9
Author: Joe Percivall <[email protected]>
Date: 2017-07-13T03:16:15Z
NIFI-2162 Updating OkHttp to 3.8.1 and OkHttp-Digest to 1.13 and
refactoring InvokeHttp to adjust for changes
----
> InvokeHttp's underlying library for Digest Auth uses the Android logger
> -----------------------------------------------------------------------
>
> Key: NIFI-2162
> URL: https://issues.apache.org/jira/browse/NIFI-2162
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
>
> A user emailed the User mailing list with an issue that InvokeHttp was
> failing due to not being able to find "android/util/Log"[1]. InvokeHttp uses
> OkHttp and the library they recommend for digest authentication is
> okhttp-digest[2]. Currently okhttp-digest assumes it's running on an Android
> device and has access to the Android logger (OkHttp does not assume it's on
> an Android device).
> I raised an issue about it on the project's github page[3] and the creator
> said he "Will change this soonish."
> Once that is addressed, InvokeHttp will need to update the versions of OkHttp
> and okhttp-digest.
> [1] http://mail-archives.apache.org/mod_mbox/nifi-users/201606.mbox/browser
> [2] https://github.com/square/okhttp/issues/205
> [3] https://github.com/rburgst/okhttp-digest/issues/13
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
