[ 
https://issues.apache.org/jira/browse/NIFI-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092218#comment-16092218
 ] 

ASF GitHub Bot commented on NIFI-4175:
--------------------------------------

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2018#discussion_r128100302
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java
 ---
    @@ -401,6 +435,18 @@ private ChannelSftp getChannel(final FlowFile 
flowFile) throws IOException {
                     
ctx.getProperty(HOSTNAME).evaluateAttributeExpressions(flowFile).getValue(),
                     
ctx.getProperty(PORT).evaluateAttributeExpressions(flowFile).asInteger().intValue());
     
    +            if 
(ctx.getProperty(PROXY_HOST).evaluateAttributeExpressions(flowFile).isSet()) {
    +                final ProxyHTTP proxy = new ProxyHTTP(
    +                        
ctx.getProperty(PROXY_HOST).evaluateAttributeExpressions(flowFile).getValue(),
    +                        
ctx.getProperty(PROXY_PORT).evaluateAttributeExpressions(flowFile).asInteger()
    +                );
    +                // Check if Username is set and populate the proxy 
accordingly
    +                if 
(ctx.getProperty(PROXY_USERNAME).evaluateAttributeExpressions(flowFile).isSet())
 {
    +                    
proxy.setUserPasswd(ctx.getProperty(PROXY_USERNAME).evaluateAttributeExpressions(flowFile).getValue(),
 
ctx.getProperty(PROXY_PASSWORD).evaluateAttributeExpressions(flowFile).getValue());
    --- End diff --
    
    ````
    [WARNING] 
src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java[445] 
(sizes) LineLength: Line is longer than 200 characters (found 206).
    ````


> Add Proxy Properties to SFTP Processors
> ---------------------------------------
>
>                 Key: NIFI-4175
>                 URL: https://issues.apache.org/jira/browse/NIFI-4175
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Grant Langlois
>            Assignee: Andre F de Miranda
>            Priority: Minor
>
> Add proxy server configuration as properties to the Nifi SFTP components. 
> Specifically add properties for:
> Proxy Type: JSCH supported proxies including SOCKS4, SOCKS5 and HTTP
> Proxy Host
> Proxy Port
> Proxy Username
> Proxy Password
> This would allow these properties to be configured for each processor. These 
> properties would align with what is configurable for the JSCH session and 
> shouldn't require any additional dependencies.
> This proposal is similar to what is already implemented for the FTP processors



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to