[ 
https://issues.apache.org/jira/browse/NIFI-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092570#comment-16092570
 ] 

ASF GitHub Bot commented on NIFI-4175:
--------------------------------------

Github user trixpan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2018#discussion_r128152991
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java
 ---
    @@ -92,6 +93,39 @@
             .defaultValue("true")
             .required(true)
             .build();
    +    public static final PropertyDescriptor PROXY_HOST = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    @pvillard31 I saw that and considered it but ended up adopting the current 
approach due to my view that I prefer not supporting SOCKS ... Don't get me 
wrong, I appreciate the reason why SOCKS exists but most processors are only 
able to support HTTP so I rather provide... consistency (I know I have been 
sounding repetitive lately... 😄 )
    
    Since FTP already supports SOCKS I reckon we can leave it there, but for 
SFTP I rather not add it at all.
    
    Let me know if you agree and I will adjust accordingly. 


> Add Proxy Properties to SFTP Processors
> ---------------------------------------
>
>                 Key: NIFI-4175
>                 URL: https://issues.apache.org/jira/browse/NIFI-4175
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Grant Langlois
>            Assignee: Andre F de Miranda
>            Priority: Minor
>
> Add proxy server configuration as properties to the Nifi SFTP components. 
> Specifically add properties for:
> Proxy Type: JSCH supported proxies including SOCKS4, SOCKS5 and HTTP
> Proxy Host
> Proxy Port
> Proxy Username
> Proxy Password
> This would allow these properties to be configured for each processor. These 
> properties would align with what is configurable for the JSCH session and 
> shouldn't require any additional dependencies.
> This proposal is similar to what is already implemented for the FTP processors



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to