Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2018#discussion_r128152991
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java
---
@@ -92,6 +93,39 @@
.defaultValue("true")
.required(true)
.build();
+ public static final PropertyDescriptor PROXY_HOST = new
PropertyDescriptor.Builder()
--- End diff --
@pvillard31 I saw that and considered it but ended up adopting the current
approach due to my view that I prefer not supporting SOCKS ... Don't get me
wrong, I appreciate the reason why SOCKS exists but most processors are only
able to support HTTP so I rather provide... consistency (I know I have been
sounding repetitive lately... ð )
Since FTP already supports SOCKS I reckon we can leave it there, but for
SFTP I rather not add it at all.
Let me know if you agree and I will adjust accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
