Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2018#discussion_r128101394
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java
 ---
    @@ -92,6 +93,39 @@
             .defaultValue("true")
             .required(true)
             .build();
    +    public static final PropertyDescriptor PROXY_HOST = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    I'm wondering if, since FileTransfer is only used for FTP and SFTP, it 
would make sens to move the proxy-related properties to FileTransfer instead of 
duplicating code. I believe, as far as I can see, that we could use the 
existing properties in FTPTransfer for SFTPTransfer as well with HTTP Proxy and 
SOCK proxy. Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to