[
https://issues.apache.org/jira/browse/NIFI-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095549#comment-16095549
]
ASF GitHub Bot commented on NIFI-4087:
--------------------------------------
GitHub user Leah-Anderson opened a pull request:
https://github.com/apache/nifi/pull/2026
NIFI-4087 Fix to allow exclusion of filename from tika criteria.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leah-Anderson/nifi NIFI-4087
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2026.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2026
----
commit 8666e0cecd0fb81b835e19e32818318a88116cd2
Author: Leah <[email protected]>
Date: 2017-07-20T23:20:54Z
NIFI-4087 Fix to allow exclusion of filename from tika criteria.
----
> IdentifyMimeType: Optionally exclude filename from criteria
> -----------------------------------------------------------
>
> Key: NIFI-4087
> URL: https://issues.apache.org/jira/browse/NIFI-4087
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.3.0, 0.7.4
> Reporter: Brandon DeVries
> Priority: Minor
> Attachments: NIFI-4087-Add-option-to-exclude-filename-from-tika.patch
>
>
> In IdentifyMimeType\[1], the filename is always (when on-null) passed to tika
> as a criteria in determining the mime type. However, there are cases when
> the filename may be known to be misleading (e.g. after decompression via
> CompressContent with "Update Filename" set to false). We should add a
> boolean processor property (default true) indicating whether or not to pass
> the filename to tika.
> \[1]
> https://github.com/apache/nifi/blob/a9a9b67430b33944b5eefa17cb85b5dd42c8d1fc/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java#L126-L129
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
