[
https://issues.apache.org/jira/browse/NIFI-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096745#comment-16096745
]
ASF GitHub Bot commented on NIFI-4087:
--------------------------------------
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2026
will give this a manual test run soon. For future contributions it is
probably easiest if you add commits to your PR rather than force pushing over
top at least during the review phase. This makes it easier on the reviewer
because they can see the diffs between review/change cycles. At the end the
reviewer might ask you to squash/rebase or they can do it for you when they
merge.
If you have any questions on that let us know.
Thanks again for contributing
> IdentifyMimeType: Optionally exclude filename from criteria
> -----------------------------------------------------------
>
> Key: NIFI-4087
> URL: https://issues.apache.org/jira/browse/NIFI-4087
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.3.0, 0.7.4
> Reporter: Brandon DeVries
> Priority: Minor
> Attachments: NIFI-4087-Add-option-to-exclude-filename-from-tika.patch
>
>
> In IdentifyMimeType\[1], the filename is always (when on-null) passed to tika
> as a criteria in determining the mime type. However, there are cases when
> the filename may be known to be misleading (e.g. after decompression via
> CompressContent with "Update Filename" set to false). We should add a
> boolean processor property (default true) indicating whether or not to pass
> the filename to tika.
> \[1]
> https://github.com/apache/nifi/blob/a9a9b67430b33944b5eefa17cb85b5dd42c8d1fc/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java#L126-L129
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
