[ 
https://issues.apache.org/jira/browse/NIFI-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164982#comment-16164982
 ] 

ASF GitHub Bot commented on NIFI-4363:
--------------------------------------

Github user jtstorck commented on the issue:

    https://github.com/apache/nifi/pull/2136
  
    `JAVA_OPTS` or `JVM_ARGS` would be fine, though I'm still okay with 
`JAVA_ARGS` since technically they are arguments to java itself.  I used 
`JAVA_ARGS` because that's what the .bat scripts were using, and I was trying 
to establish parity between the .sh and .bat scripts. If everything else looks 
good to you, you can make the change before committing, or I can push an update 
to the PR.


> Parameterize heap allocation in NiFi Toolkit scripts
> ----------------------------------------------------
>
>                 Key: NIFI-4363
>                 URL: https://issues.apache.org/jira/browse/NIFI-4363
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Tools and Build
>    Affects Versions: 1.3.0
>            Reporter: Jeff Storck
>            Assignee: Jeff Storck
>
> Replace hardcoded heap allocation of java in scripts with parameterized 
> values.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to