[
https://issues.apache.org/jira/browse/NIFI-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167353#comment-16167353
]
ASF GitHub Bot commented on NIFI-4363:
--------------------------------------
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2136
Thanks @yuri1969 . @jtstorck I found other batch files already use
`JAVA_ARGS` such as `run-nifi.bat`, but those usages are enclosed within the
batch file itself.
So, I think we can still establish parity between .sh and .bat scripts when
those existing bat scripts exposes the config to user land, by using
`JAVA_OPTS`. The reason I care about naming here is, because the name is
exposed to user code base.
I've created a commit based on yours.
https://github.com/ijokarumawak/nifi/commit/8fca2515d3ca422e6669f7e8a6d111eb0a218205
If it looks good, please cherry-pick it, or just updating your PR is fine
for me, too.
Other part, I'm +1 for this PR, thanks!
> Parameterize heap allocation in NiFi Toolkit scripts
> ----------------------------------------------------
>
> Key: NIFI-4363
> URL: https://issues.apache.org/jira/browse/NIFI-4363
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Affects Versions: 1.3.0
> Reporter: Jeff Storck
> Assignee: Jeff Storck
>
> Replace hardcoded heap allocation of java in scripts with parameterized
> values.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
