[
https://issues.apache.org/jira/browse/NIFI-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169461#comment-16169461
]
ASF GitHub Bot commented on NIFI-2663:
--------------------------------------
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/2154
@SebastianCarroll the way the test cases are set up you don't need to copy
and paste the tests themselves. What you'll do is extend common/Test*MqttCommon
in order to get all the junit tests. See
[TestPublishMQTT](https://github.com/apache/nifi/blob/7923fd04c35737df8145b213536bdf333ef72713/nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/test/java/org/apache/nifi/processors/mqtt/integration/TestPublishMQTT.java#L38)
in the integration folder as an example.
While it may be just a 3 letter change on our end, you're changing a core
configuration of the underlying implementation. So verifying that is helpful.
Also, what is the purpose of the changes you've made to MqttTestClient.java
and where did you copy & paste the comments/code from?
Lastly, you have some check style issues (can be seen by running "mvn clean
install -Pcontrib-check"). Here's what I see:
`[WARNING]
src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java[104:52]
(whitespace) OperatorWrap: '||' should be on a new line.
[WARNING]
src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java[105:53]
(whitespace) OperatorWrap: '||' should be on a new line.
[WARNING]
src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java[106:52]
(whitespace) OperatorWrap: '||' should be on a new line.
[WARNING]
src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java[296:62]
(whitespace) OperatorWrap: '||' should be on a new line.
[WARNING]
src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java[20]
(imports) AvoidStarImport: Using the '.*' form of import should be avoided -
org.eclipse.paho.client.mqttv3.*.
[WARNING]
src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java[375:43]
(whitespace) FileTabCharacter: Line contains a tab character.
[WARNING]
src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java[476:43]
(whitespace) FileTabCharacter: Line contains a tab character.`
> Add Websocket support for MQTT protocol
> ---------------------------------------
>
> Key: NIFI-2663
> URL: https://issues.apache.org/jira/browse/NIFI-2663
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.0.0, 0.7.0, 0.6.1
> Reporter: Andrew Psaltis
> Assignee: Andrew Psaltis
>
> Today NiFi only supports MQTT over plain TCP using the PublishMQTT and
> ConsumeMQTT processors. However, there are many cases in the IoT world where
> WebSockets (secure and not) is the preferred transport mechanism for MQTT.
> This JIRA is to enhance those processors to also support WS.
> Following are the basics of what is required:
>
> 1) Require to configure web socket as the transport protocol, currently
> PublishMQTT processor supports TCP as the only transport protocol
> 2) URL input for the Web socket transport should be in the format of
> ws://IPAddress:websocket_listening_port, as of now it accepts only TCP url,
> and a bulletin is raised if a protocol other than tcp or ssl is used.
> 3) Similar to TCP non-secured and secured publisher we should
> extend/provide processor to support WS and WSS transport protocols
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
