[ 
https://issues.apache.org/jira/browse/NIFI-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195809#comment-16195809
 ] 

ASF GitHub Bot commented on NIFI-2663:
--------------------------------------

Github user SebastianCarroll commented on the issue:

    https://github.com/apache/nifi/pull/2154
  
    I've added  an abstract `getUri` method which allows me to subclass 
`TestConsumeMQTT` -> `TestConsumeMqttWS` and `TestConsumeMqttSSL` -> 
`TestConsumeMqttWSS` and only override the getUri method to return the `ws://` 
and `wss://` protocols respectively but still run the same set of tests for the 
base classes. 
    
    This approach is currently failing with the error `java.io.IOException: 
WebSocket Response header: Invalid response from Server, It may not support 
WebSockets.`. Initially I thought that the Moquette server may not support 
WebSockets but on closer inspection it looks like a misconfiguration.
    
    Putting aside the current test failures, does this subclassing test 
strategy make sense?


> Add Websocket support for MQTT protocol
> ---------------------------------------
>
>                 Key: NIFI-2663
>                 URL: https://issues.apache.org/jira/browse/NIFI-2663
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.0.0, 0.7.0, 0.6.1
>            Reporter: Andrew Psaltis
>            Assignee: Andrew Psaltis
>
> Today NiFi only supports MQTT over plain TCP using the PublishMQTT and 
> ConsumeMQTT processors. However, there are many cases in the IoT world where 
> WebSockets (secure and not) is the preferred transport mechanism for MQTT.  
> This JIRA is to enhance those processors to also support WS.
> Following are the basics of what is required:
>  
> 1)      Require to configure web socket as the transport protocol, currently 
> PublishMQTT processor supports TCP as the only transport protocol
> 2)      URL input for the Web socket transport should be in the format of 
> ws://IPAddress:websocket_listening_port, as of now it accepts only TCP url, 
> and a bulletin is raised if a protocol other than tcp or ssl is used.
> 3)      Similar to TCP non-secured and secured publisher we should 
> extend/provide processor to support WS and WSS transport protocols



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to