Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2166#discussion_r140352593
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java
 ---
    @@ -243,14 +243,14 @@ public void onTrigger(final ProcessContext context, 
final ProcessSessionFactory
                     maxValueSelectColumns.add("MAX(" + colName + ") " + 
colName);
                     String maxValue = getColumnStateMaxValue(tableName, 
statePropertyMap, colName);
                     if (!StringUtils.isEmpty(maxValue)) {
    -                    Integer type = getColumnType(tableName, colName);
    +                    Integer type = getColumnType(context, tableName, 
colName, finalFileToProcess);
    --- End diff --
    
    Probably instead of change `getColumnType`, we can add calling `setup` if 
`columnTypeMap.isEmpty()`, before `getColumnType` here. Which makes it more 
readable.


---

Reply via email to