[GitHub] nifi issue #2166: NIFI-4395 - GenerateTableFetch can't fetch column type by ...

[yjhyjhyjh0]

Github user yjhyjhyjh0 commented on the issue:

    https://github.com/apache/nifi/pull/2166
  
    Thanks for the detail comment and suggestion.
    That helps me a lot.
    
    Some fix by suggestion like.
    1 - put back StringmaxValueColumnNames to GenerateTableFetch to avoid NPE 
unit test fail.
         (Originally forget to include this line)
    2 - move re-cache method, calling super.setup(), before the getColumnType 
to provide more 
    readable code. 
    3 - Remove ternary operator because evaluateAttributeExpressions already 
can handle null flowfile.
    
    Thanks


---