Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r143279988
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java
---
@@ -290,6 +292,9 @@ public void process(final OutputStream out) throws
IOException {
}
}
+ // set query timeout
+ st.setQueryTimeout(queryTimeout);
--- End diff --
I get the point of the customValidate but I'd keep its check but mark it as
valid whether the timeout method is supported or not. YOu can set some
processor instance boolean to advise whether it is supported then in this
call/check set the timeout if it is and ignore it if not. Otherwise we're
requiring them to use a version of hive which supports it and that seems a
little heavy handed. It is probably a good idea to do the current validation
logic in some other lifecycle call like 'onAdded' or something, warn if
timeouts not supported and point out hanging threads are possible, and keep
going.
---
