Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r143281834
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java
---
@@ -66,6 +71,38 @@
.addValidator(StandardValidators.CHARACTER_SET_VALIDATOR)
.build();
+ public static final PropertyDescriptor QUERY_TIMEOUT = new
PropertyDescriptor.Builder()
+ .name("hive-query-timeout")
+ .displayName("Query timeout")
+ .description("Sets the number of seconds the driver will wait
for a query to execute. "
+ + "A value of 0 means no timeout. This feature is
available starting with Hive 2.1.")
--- End diff --
The part about the feature availability is nice if/when there's a choice,
but for now it's not technically germane, since the Hive NAR ships with a
particular version of Hive. I will remove that part and merge, the rest LGTM :)
---