Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2089#discussion_r143315219
  
    --- Diff: 
nifi-nar-bundles/nifi-ldap-iaa-providers-bundle/nifi-ldap-iaa-providers/src/main/java/org/apache/nifi/ldap/LdapProvider.java
 ---
    @@ -38,11 +38,10 @@
     import 
org.springframework.ldap.core.support.SimpleDirContextAuthenticationStrategy;
     import org.springframework.security.authentication.BadCredentialsException;
     import 
org.springframework.security.authentication.UsernamePasswordAuthenticationToken;
    +import 
org.springframework.security.authentication.encoding.LdapShaPasswordEncoder;
     import org.springframework.security.core.Authentication;
     import 
org.springframework.security.core.userdetails.UsernameNotFoundException;
    -import 
org.springframework.security.ldap.authentication.AbstractLdapAuthenticationProvider;
    -import org.springframework.security.ldap.authentication.BindAuthenticator;
    -import 
org.springframework.security.ldap.authentication.LdapAuthenticationProvider;
    +import org.springframework.security.ldap.authentication.*;
    --- End diff --
    
    I imagine this was your IDE collapsing these imports, but our [coding style 
guidelines](https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-CodeStyle)
 discourage the use of wildcard imports. 


---

Reply via email to