Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2089#discussion_r143315312
  
    --- Diff: 
nifi-nar-bundles/nifi-ldap-iaa-providers-bundle/nifi-ldap-iaa-providers/src/main/java/org/apache/nifi/ldap/LdapProvider.java
 ---
    @@ -193,8 +192,41 @@ public final void onConfigured(final 
LoginIdentityProviderConfigurationContext c
     
             final LdapUserSearch userSearch = new 
FilterBasedLdapUserSearch(userSearchBase, userSearchFilter, context);
     
    -        // bind
    -        final BindAuthenticator authenticator = new 
BindAuthenticator(context);
    +
    +        String rawAuthenticatorType = 
configurationContext.getProperty("Authenticator Type");
    +        AuthenticatorType authenticatorType;
    +
    +        if (StringUtils.isBlank(rawAuthenticatorType))
    --- End diff --
    
    Similarly to above, braces are encouraged to be on the same line as control 
statements to reduce code height. You can download the checkstyle rules for 
your IDE and have them automatically applied. 


---

Reply via email to