Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2199#discussion_r144530989
  
    --- Diff: 
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java
 ---
    @@ -138,10 +168,11 @@ protected void init(final 
ProcessorInitializationContext context) {
             descriptors.add(SOLR_TYPE);
             descriptors.add(SOLR_LOCATION);
             descriptors.add(COLLECTION);
    +        descriptors.add(RETURN_TYPE);
    +        descriptors.add(RECORD_WRITER);
             descriptors.add(SOLR_QUERY);
    -        descriptors.add(RETURN_FIELDS);
    -        descriptors.add(SORT_CLAUSE);
    --- End diff --
    
    Is it safe to remove an existing property? The existing code should not 
sort result anyway, or should store last sorted field value to paginate 
properly when docs with the same date split more than one page. So I think it's 
safe..


---

Reply via email to