Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2199#discussion_r144526595
  
    --- Diff: 
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrProcessor.java
 ---
    @@ -275,7 +275,7 @@ protected final boolean isBasicAuthEnabled() {
         }
     
         @Override
    -    protected final Collection<ValidationResult> 
customValidate(ValidationContext context) {
    +    protected Collection<ValidationResult> 
customValidate(ValidationContext context) {
    --- End diff --
    
    Shouldn't we add another protected method to override at sub-classes?


---

Reply via email to