[ 
https://issues.apache.org/jira/browse/NIFI-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205714#comment-16205714
 ] 

ASF GitHub Bot commented on NIFI-4465:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2194#discussion_r144811262
  
    --- Diff: 
nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/main/java/org/apache/nifi/processors/poi/ConvertExcelToCSVProcessor.java
 ---
    @@ -101,6 +100,34 @@
                 .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor FIRST_ROW = new 
PropertyDescriptor
    --- End diff --
    
    If I understand the behavior correctly, this property should be named like 
'Number of skip rows'. Also, we should mention that skips empty rows 
automatically regardless to this setting.


> ConvertExcelToCSV Data Formatting and Delimiters
> ------------------------------------------------
>
>                 Key: NIFI-4465
>                 URL: https://issues.apache.org/jira/browse/NIFI-4465
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> The ConvertExcelToCSV Processor does not output cell values using the 
> formatting set in Excel.
> There are also no delimiter options available for column/record delimiting.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to