[
https://issues.apache.org/jira/browse/NIFI-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205713#comment-16205713
]
ASF GitHub Bot commented on NIFI-4465:
--------------------------------------
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2194#discussion_r144812713
--- Diff:
nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/main/java/org/apache/nifi/processors/poi/ConvertExcelToCSVProcessor.java
---
@@ -101,6 +100,34 @@
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ public static final PropertyDescriptor FIRST_ROW = new
PropertyDescriptor
+ .Builder().name("excel-extract-first-row")
+ .displayName("First Row")
+ .description("The row number of the header row, or first row
of data if `Has Header Line` is set to false. "
+ + "Use this to skip over rows of data at the top of
your worksheet that are not part of the dataset.")
+ .required(true)
+ .defaultValue("0")
+
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor COLUMNS_TO_SKIP = new
PropertyDescriptor
+ .Builder().name("excel-extract-column-to-skip")
+ .displayName("Columns To Skip")
+ .description("Comma delimited list of column numbers to skip.
Use the columns number and not the letter designation. "
+ + "Use this to skip over columns anywhere in your
worksheet that you don't want extracted as part of the record.")
+ .required(false)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor FORMAT_VALUES = new
PropertyDescriptor.Builder()
+ .name("excel-format-values")
+ .displayName("Format Cell Values")
+ .description("Should the cell values be written too CSV using
the formatting applied in Excel, or should they be printed as raw values.")
+ .allowableValues("true", "false")
+ .defaultValue("true")
--- End diff --
Only to preserve existing flow behavior (it's possible that some user has
been running a flow reading excel files with styles), `false` might be better
as default value.
> ConvertExcelToCSV Data Formatting and Delimiters
> ------------------------------------------------
>
> Key: NIFI-4465
> URL: https://issues.apache.org/jira/browse/NIFI-4465
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Peter Wicks
> Assignee: Peter Wicks
> Priority: Minor
> Fix For: 1.5.0
>
>
> The ConvertExcelToCSV Processor does not output cell values using the
> formatting set in Excel.
> There are also no delimiter options available for column/record delimiting.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)