Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2199#discussion_r145690789
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java
---
@@ -66,42 +79,72 @@
import org.apache.solr.common.SolrDocument;
import org.apache.solr.common.SolrDocumentList;
import org.apache.solr.common.SolrInputDocument;
+import org.apache.solr.common.params.CursorMarkParams;
-@Tags({"Apache", "Solr", "Get", "Pull"})
+@Tags({"Apache", "Solr", "Get", "Pull", "Records"})
@InputRequirement(Requirement.INPUT_FORBIDDEN)
-@CapabilityDescription("Queries Solr and outputs the results as a
FlowFile")
+@CapabilityDescription("Queries Solr and outputs the results as a FlowFile
in the format of XML or using a Record Writer")
+@Stateful(scopes = {Scope.CLUSTER}, description = "Stores latest date of
Date Field so that the same data will not be fetched multiple times.")
public class GetSolr extends SolrProcessor {
- public static final PropertyDescriptor SOLR_QUERY = new
PropertyDescriptor
- .Builder().name("Solr Query")
- .description("A query to execute against Solr")
+ public static final String STATE_MANAGER_FILTER =
"stateManager_filter";
+ public static final String STATE_MANAGER_CURSOR_MARK =
"stateManager_cursorMark";
+ public static final AllowableValue MODE_XML = new
AllowableValue("XML");
+ public static final AllowableValue MODE_REC = new
AllowableValue("Records");
+
+ public static final PropertyDescriptor RETURN_TYPE = new
PropertyDescriptor
+ .Builder().name("Return Type")
+ .displayName("Return Type")
--- End diff --
Although I haven't seen a specific guideline or documentation, other
processors prefer having `name` in lower case looks like a key of property or
configuration name such as `return_type` so that user can type the name without
worrying about spacing or case sensitivity, while `displayName` is a more
verbose human readable name.
`name` would be more important in the world of MiNiFi or other application
directly talks with NiFi API programatically.
I don't have strong opinion here but just wanted to share what those two
are.
---
