[
https://issues.apache.org/jira/browse/NIFI-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218414#comment-16218414
]
ASF GitHub Bot commented on NIFI-3402:
--------------------------------------
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2150#discussion_r146825133
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -439,6 +452,12 @@
private static final String RFC_1123 = "EEE, dd MMM yyyy HH:mm:ss
'GMT'";
private static final DateTimeFormatter DATE_FORMAT =
DateTimeFormat.forPattern(RFC_1123).withLocale(Locale.US).withZoneUTC();
+ /**
+ * The maximum size, in bytes, that the ETag cache should grow if it
is enabled.
+ * The size here is chosen arbitrarily, as the documentation doesn't
suggest a recommended value.
+ */
+ private static final int MAX_ETAG_CACHE_SIZE_BYTES = 1024 * 1024 * 10;
// 10MiB
--- End diff --
Making this configurable with a property descriptor would be a good idea. I
think two property descriptors, one for the numeric portion and the other for
the unit would be very helpful to users.
> Add ETag Support to InvokeHTTP
> ------------------------------
>
> Key: NIFI-3402
> URL: https://issues.apache.org/jira/browse/NIFI-3402
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Brandon DeVries
> Assignee: Michael Hogue
> Priority: Trivial
>
> Unlike GetHTTP, when running in "source" mode InvokeHTTP doesn't support
> ETags. It will pull from a URL as often as it is scheduled to run. When
> running with an input relationship, it would potentially make sense to not
> use the ETag. But at least in "source" mode, it seems like it should at
> least be an option.
> To maintain backwards compatibility and support the non-"source" usage, I'd
> suggest creating a new "Use ETag" property that defaults to false...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
