[ 
https://issues.apache.org/jira/browse/NIFI-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218415#comment-16218415
 ] 

ASF GitHub Bot commented on NIFI-3402:
--------------------------------------

Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2150#discussion_r146825541
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ---
    @@ -370,6 +374,14 @@
                 .allowableValues("true", "false")
                 .build();
     
    +    public static final PropertyDescriptor PROP_USE_ETAG = new 
PropertyDescriptor.Builder()
    +            .name("use-etag")
    +            .displayName("Use HTTP ETag")
    +            .required(true)
    --- End diff --
    
    This needs a `description("")` call to set a description statement on the 
property.


> Add ETag Support to InvokeHTTP
> ------------------------------
>
>                 Key: NIFI-3402
>                 URL: https://issues.apache.org/jira/browse/NIFI-3402
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Brandon DeVries
>            Assignee: Michael Hogue
>            Priority: Trivial
>
> Unlike GetHTTP, when running in "source" mode InvokeHTTP doesn't support 
> ETags.  It will pull from a URL as often as it is scheduled to run.  When 
> running with an input relationship, it would potentially make sense to not 
> use the ETag.  But at least in "source" mode, it seems like it should at 
> least be an option.
> To maintain backwards compatibility and support the non-"source" usage, I'd 
> suggest creating a new "Use ETag" property that defaults to false...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to