[
https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218829#comment-16218829
]
ASF GitHub Bot commented on MINIFICPP-265:
------------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/154
MINIFICPP-265 Disabled fsanitize=address for now, due to overly-verbo…
…se log messages. This may be re-enabled in a more controlled fashion later
on.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-265
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit 1cef7fe0f8ff1e681eea3550df8037690fa86490
Author: Andy I. Christianson <a...@andyic.org>
Date: 2017-10-24T20:27:40Z
MINIFICPP-265 Disabled fsanitize=address for now, due to overly-verbose log
messages. This may be re-enabled in a more controlled fashion later on.
----
> Disable incidental -fsanitize address
> -------------------------------------
>
> Key: MINIFICPP-265
> URL: https://issues.apache.org/jira/browse/MINIFICPP-265
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Minor
>
> From nifi dev mailing list:
> "On an earlier commit, I added the following to the root CMakeLists.txt:
>
> # Enable asan in DEBUG for compatibility with civet
> set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -fsanitize=address")
> This was, as stated in the comment, to address a compatibility issue when
> compiling in DEBUG where civet would fail to link.
> On more recent dev toolchains (devtoolset-6 SCL CentOS/GCC 6.3), this results
> in extremely verbose and unhelpful output during test runs. While I am not
> opposed to using these tools to detect legitimate memory leaks, as it stands
> currently the setting is more of a detriment to the development process. I
> think that we should either only turn this on when we deliberately intend to
> analyze memory usage, or possibly create additional unit tests to detect
> memory leaks."
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
