[
https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218832#comment-16218832
]
ASF GitHub Bot commented on MINIFICPP-265:
------------------------------------------
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/154
Opened this off a bit too soon. Let me go in and change those commented
lines into deleted lines.
> Disable incidental -fsanitize address
> -------------------------------------
>
> Key: MINIFICPP-265
> URL: https://issues.apache.org/jira/browse/MINIFICPP-265
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Minor
>
> From nifi dev mailing list:
> "On an earlier commit, I added the following to the root CMakeLists.txt:
>
> # Enable asan in DEBUG for compatibility with civet
> set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -fsanitize=address")
> This was, as stated in the comment, to address a compatibility issue when
> compiling in DEBUG where civet would fail to link.
> On more recent dev toolchains (devtoolset-6 SCL CentOS/GCC 6.3), this results
> in extremely verbose and unhelpful output during test runs. While I am not
> opposed to using these tools to detect legitimate memory leaks, as it stands
> currently the setting is more of a detriment to the development process. I
> think that we should either only turn this on when we deliberately intend to
> analyze memory usage, or possibly create additional unit tests to detect
> memory leaks."
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
