[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218880#comment-16218880 ]
ASF GitHub Bot commented on MINIFICPP-52: ----------------------------------------- Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146891895 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class declaration + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef __EXTRACT_TEXT_H__ +#define __EXTRACT_TEXT_H__ + +#include "FlowFileRecord.h" +#include "core/Processor.h" +#include "core/ProcessSession.h" +#include "core/Resource.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace processors { + +//! ExtractText Class +class ExtractText : public core::Processor { +public: + //! Constructor + /*! + * Create a new processor + */ + ExtractText(std::string name, uuid_t uuid = NULL) + : Processor(name, uuid) + { + logger_ = logging::LoggerFactory<ExtractText>::getLogger(); + } + //! Destructor + virtual ~ExtractText() + { + } --- End diff -- Clang-tidy suggests using override here. Do we even need this destructor? > Implement ExtractText processor > ------------------------------- > > Key: MINIFICPP-52 > URL: https://issues.apache.org/jira/browse/MINIFICPP-52 > Project: NiFi MiNiFi C++ > Issue Type: Improvement > Reporter: Andrew Christianson > Assignee: Andrew Christianson > > Implement the ExtractText processor as it has clearly utility in simple > endpoint flows. -- This message was sent by Atlassian JIRA (v6.4.14#64029)