[ 
https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218910#comment-16218910
 ] 

ASF GitHub Bot commented on MINIFICPP-52:
-----------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146897792
  
    --- Diff: libminifi/test/unit/ExtractTextTest.cpp ---
    @@ -0,0 +1,101 @@
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only 
do this in one cpp file
    +#include <uuid/uuid.h>
    +#include <fstream>
    +#include <map>
    +#include <memory>
    +#include <utility>
    +#include <string>
    +#include <set>
    +#include <iostream>
    +
    +#include "../TestBase.h"
    +#include "core/Core.h"
    +
    +#include "core/FlowFile.h"
    +#include "core/Processor.h"
    +#include "core/ProcessContext.h"
    +#include "core/ProcessSession.h"
    +#include "core/ProcessorNode.h"
    +
    +#include "processors/ExtractText.h"
    +#include "processors/LogAttribute.h"
    +
    +const char* TEST_TEXT = "Test text\n";
    +const char* TEST_FILE = "test_file.txt";
    +const char* TEST_ATTR = "ExtractedText";
    +
    +TEST_CASE("Test Creation of ExtractText", "[extracttextCreate]") {
    +    TestController testController;
    +    std::shared_ptr<core::Processor> processor = 
std::make_shared<org::apache::nifi::minifi::processors::ExtractText>("processorname");
    +    REQUIRE(processor->getName() == "processorname");
    +    uuid_t processoruuid;
    +    REQUIRE(true == processor->getUUID(processoruuid));
    +}
    +
    +TEST_CASE("Test usage of ExtractText", "[extracttextTest]") {
    +    TestController testController;
    +    
LogTestController::getInstance().setTrace<org::apache::nifi::minifi::processors::ExtractText>();
    +    
LogTestController::getInstance().setTrace<org::apache::nifi::minifi::processors::PutFile>();
    +    
LogTestController::getInstance().setTrace<org::apache::nifi::minifi::processors::GetFile>();
    +    
LogTestController::getInstance().setTrace<org::apache::nifi::minifi::processors::LogAttribute>();
    +    LogTestController::getInstance().setTrace<core::ProcessSession>();
    +    
LogTestController::getInstance().setTrace<core::repository::VolatileContentRepository>();
    +    
LogTestController::getInstance().setTrace<org::apache::nifi::minifi::Connection>();
    +    
LogTestController::getInstance().setTrace<org::apache::nifi::minifi::core::Connectable>();
    +    
LogTestController::getInstance().setTrace<org::apache::nifi::minifi::core::FlowFile>();
    +
    +    std::shared_ptr<TestPlan> plan = testController.createPlan();
    +    std::shared_ptr<TestRepository> repo = 
std::make_shared<TestRepository>();
    +
    +    char dir[] = "/tmp/gt.XXXXXX";
    +
    +    REQUIRE(testController.createTempDirectory(dir) != nullptr);
    +    std::shared_ptr<core::Processor> getfile = 
plan->addProcessor("GetFile", "getfileCreate2");
    +    plan->setProperty(getfile, 
org::apache::nifi::minifi::processors::GetFile::Directory.getName(), dir);
    +    plan->setProperty(getfile, 
org::apache::nifi::minifi::processors::GetFile::KeepSourceFile.getName(), 
"true");
    +
    +    std::shared_ptr<core::Processor> maprocessor = 
plan->addProcessor("ExtractText", "testExtractText", 
core::Relationship("success", "description"), true);
    +    plan->setProperty(maprocessor, 
org::apache::nifi::minifi::processors::ExtractText::Attribute.getName(), 
TEST_ATTR);
    +
    +    std::shared_ptr<core::Processor> laprocessor = 
plan->addProcessor("LogAttribute", "outputLogAttribute", 
core::Relationship("success", "description"), true);
    +    plan->setProperty(laprocessor, 
org::apache::nifi::minifi::processors::LogAttribute::AttributesToLog.getName(), 
TEST_ATTR);
    +
    +    std::stringstream ss1;
    +    ss1 << dir << "/" << TEST_FILE;
    +    std::string test_file_path = ss1.str();
    +
    +    std::ofstream test_file(test_file_path);
    +    if (test_file.is_open()) {
    +        test_file << TEST_TEXT << std::endl;
    +        test_file.close();
    +    }
    +
    +    plan->runNextProcessor();  // GetFile
    +    plan->runNextProcessor();  // ExtractText
    +    plan->runNextProcessor();  // LogAttribute
    +
    +    std::stringstream ss2;
    +    ss2 << "key:" << TEST_ATTR << " value:" << TEST_TEXT;
    --- End diff --
    
    Good.


> Implement ExtractText processor
> -------------------------------
>
>                 Key: MINIFICPP-52
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-52
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>
> Implement the ExtractText processor as it has clearly utility in simple 
> endpoint flows.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to