[
https://issues.apache.org/jira/browse/MINIFICPP-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227168#comment-16227168
]
ASF GitHub Bot commented on MINIFICPP-266:
------------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/165
MINIFICPP-266: Make wait_time purely virtual so that they must be imp…
…lemented by the thread or executor
MINIFICPP-266: Update Unit test to ensure we are abiding by heartbeat period
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
commit de2664d1fdbedec32130e4c97a28a6638daaa65f
Author: Marc Parisi <[email protected]>
Date: 2017-10-29T16:13:04Z
MINIFICPP-266: Make wait_time purely virtual so that they must be
implemented by the thread or executor
MINIFICPP-266: Update Unit test to ensure we are abiding by heartbeat period
----
> C2 Threading uses a wait time of 0
> ----------------------------------
>
> Key: MINIFICPP-266
> URL: https://issues.apache.org/jira/browse/MINIFICPP-266
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: marco polo
> Assignee: marco polo
> Priority: Blocker
> Fix For: 0.3.0
>
>
> This causes a spin with no wait, spiking cpu usage to 100% if C2 is virtually
> disabled. We should also explore better disabling these threading components
> if there is no work to do. Thanks to [~achristianson] for identifying this
> and triaging.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
