[
https://issues.apache.org/jira/browse/MINIFICPP-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227309#comment-16227309
]
ASF GitHub Bot commented on MINIFICPP-266:
------------------------------------------
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/165
LGTM, however I would suggest using the override [1] instead of virtual in
the subclasses.
[1]: http://en.cppreference.com/w/cpp/language/override
> C2 Threading uses a wait time of 0
> ----------------------------------
>
> Key: MINIFICPP-266
> URL: https://issues.apache.org/jira/browse/MINIFICPP-266
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: marco polo
> Assignee: marco polo
> Priority: Blocker
> Fix For: 0.3.0
>
>
> This causes a spin with no wait, spiking cpu usage to 100% if C2 is virtually
> disabled. We should also explore better disabling these threading components
> if there is no work to do. Thanks to [~achristianson] for identifying this
> and triaging.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
