Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/163#discussion_r148305479
  
    --- Diff: libminifi/CMakeLists.txt ---
    @@ -58,7 +75,19 @@ include_directories(../thirdparty/jsoncpp/include)
     include_directories(../thirdparty/concurrentqueue/)
     include_directories(include)
     
    -file(GLOB SOURCES  "src/core/logging/*.cpp"  "src/core/state/*.cpp" 
"src/c2/protocols/*.cpp" "src/c2/*.cpp" "src/io/*.cpp" "src/io/tls/*.cpp" 
"src/core/controller/*.cpp" "src/controllers/*.cpp" "src/core/*.cpp"  
"src/core/repository/*.cpp" "src/core/yaml/*.cpp" "src/core/reporting/*.cpp"  
"src/provenance/*.cpp" "src/utils/*.cpp" "src/*.cpp")
    +if (NOT DISABLE_LUA_SCRIPTING)
    +    set(LUA_SOURCES_GLOB "src/lua/*.cpp")
    --- End diff --
    
    libminifi/CMakeLists would definitely be much cleaner with an extension


---

Reply via email to