Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/163#discussion_r148306705
  
    --- Diff: libminifi/include/python/PyProcessSession.h ---
    @@ -0,0 +1,87 @@
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#ifndef NIFI_MINIFI_CPP_PYPROCESSESSION_H
    +#define NIFI_MINIFI_CPP_PYPROCESSESSION_H
    +
    +#include <pybind11/embed.h>
    +
    +#include <core/ProcessSession.h>
    +#include <python/PyBaseStream.h>
    +#include <script/ScriptFlowFile.h>
    +
    +namespace org {
    +namespace apache {
    +namespace nifi {
    +namespace minifi {
    +namespace python {
    +
    +namespace py = pybind11;
    +
    +class PyProcessSession {
    --- End diff --
    
    same RE the const ref shared pointers. 


---

Reply via email to