[
https://issues.apache.org/jira/browse/MINIFICPP-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235580#comment-16235580
]
ASF GitHub Bot commented on MINIFICPP-110:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/163#discussion_r147788104
--- Diff: CMakeLists.txt ---
@@ -38,19 +38,35 @@ endif(CCACHE_FOUND)
#### Establish Project Configuration ####
# Enable usage of the VERSION specifier
include(CheckCXXCompilerFlag)
+CHECK_CXX_COMPILER_FLAG("-std=c++14 " COMPILER_SUPPORTS_CXX14)
+CHECK_CXX_COMPILER_FLAG("-std=c++1y " COMPILER_SUPPORTS_CXX1Y)
CHECK_CXX_COMPILER_FLAG("-std=c++11 " COMPILER_SUPPORTS_CXX11)
CHECK_CXX_COMPILER_FLAG("-std=c++0x " COMPILER_SUPPORTS_CXX0X)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ")
SET(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}")
-if(COMPILER_SUPPORTS_CXX11)
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
-elseif(COMPILER_SUPPORTS_CXX0X)
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
+
+if (NOT DISABLE_LUA_SCRIPTING)
--- End diff --
With the reliance on C++14 should we make this disabled by default since it
would change our base version of gcc?
> Implement ExecuteScript
> -----------------------
>
> Key: MINIFICPP-110
> URL: https://issues.apache.org/jira/browse/MINIFICPP-110
> Project: NiFi MiNiFi C++
> Issue Type: New Feature
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> Initially support python and lua.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
