[ 
https://issues.apache.org/jira/browse/MINIFICPP-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235587#comment-16235587
 ] 

ASF GitHub Bot commented on MINIFICPP-110:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/163#discussion_r148305726
  
    --- Diff: libminifi/include/lua/LuaProcessSession.h ---
    @@ -0,0 +1,86 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#ifndef NIFI_MINIFI_CPP_LUAPROCESSSESSION_H
    +#define NIFI_MINIFI_CPP_LUAPROCESSSESSION_H
    +
    +#include <sol.hpp>
    +
    +#include <core/ProcessSession.h>
    +#include <script/ScriptFlowFile.h>
    +#include <lua/LuaBaseStream.h>
    +
    +namespace org {
    +namespace apache {
    +namespace nifi {
    +namespace minifi {
    +namespace lua {
    +
    +class LuaProcessSession {
    + public:
    +  explicit LuaProcessSession(core::ProcessSession *session);
    +
    +  std::shared_ptr<script::ScriptFlowFile> get();
    +  std::shared_ptr<script::ScriptFlowFile> create();
    +  std::shared_ptr<script::ScriptFlowFile> 
create(std::shared_ptr<script::ScriptFlowFile> flow_file);
    +  void transfer(std::shared_ptr<script::ScriptFlowFile> flow_file, 
core::Relationship relationship);
    --- End diff --
    
    const ref shared ptrs will help reduce the cost of ref counting, though 
small. 


> Implement ExecuteScript
> -----------------------
>
>                 Key: MINIFICPP-110
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-110
>             Project: NiFi MiNiFi C++
>          Issue Type: New Feature
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>            Priority: Major
>
> Initially support python and lua.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to