[
https://issues.apache.org/jira/browse/NIFI-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235977#comment-16235977
]
ASF GitHub Bot commented on NIFI-4559:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2246
NIFI-4559: Add non-zero status relationship to ExecuteStreamCommand
Sorry about the whitespace changes, I must have slightly different (but
still compliant) formatting settings in my IDE.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4559
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2246
----
----
> ExecuteStreamCommand should have a failure relationship
> -------------------------------------------------------
>
> Key: NIFI-4559
> URL: https://issues.apache.org/jira/browse/NIFI-4559
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.4.0
> Reporter: Joseph Witt
> Assignee: Matt Burgess
> Priority: Major
>
> ExecuteStreamCommand only has a success relationship. The gist is it
> executes the command, captures the output stream, code, etc.. and stores the
> necessary content and attributes.
> However, for those wanting to see the status code as an indicator of failure
> they have to create a flow which checks, loops, etc.. This is more work than
> necessary since the processor can provide a better indicator. By adding a
> failure relationship we can route results and status codes for non-zero to
> this relationship. We'll have to consider backward compatibility friendly
> ideas but the gist is to make this common failure/retry pattern easier to
> configure and track.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
